cnf/configure: use bash instead of sh#155
Open
kanavin wants to merge 1 commit into
Open
Conversation
Otherwise trnl gets set to "\n" with bash and "" with dash which leads to different behavior depending on the build host, breaking reproducibility. Reported: arsv#87
Owner
|
Mon, Mar 31, 2025 at 03:58:22AM -0700, Alexander Kanavin wrote:
use bash instead of sh
Followed by a PR "don't use bash" because of course there are people
running it with only dash/ash/whatever.
Otherwise trnl gets set to "\n" with bash and "" with dash which leads to
different behavior depending on the build host, breaking reproducibility.
What do you mean by trnl, the value in config.sh?
Can you post expected/actual results, and how you're running it?
I'm not getting any difference bash-to-dash. But I'm also getting trnl='tr',
so there's probably something else going on.
|
Contributor
Author
|
If I read #87 right, the trnl issue was fixed in a different way in perl-cross long time ago? I might have missed that, then this PR is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise trnl gets set to "\n" with bash and "" with dash which leads to different behavior depending on the build host, breaking reproducibility.
Reported: #87