Repository navigation
Advertise per-pod external listener when external access is enabled (3.8.1) - #61
Merged
Merged
Conversation
Signed-off-by: Abdullah Al Masood <masood@appscode.com>
The org requires actions to be pinned to a full-length commit SHA, so the ci and release workflows failed at setup. Pin them and bump to the versions pgpool2 uses. Signed-off-by: Abdullah Al Masood <masood@appscode.com>
ArnobKumarSaha
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When external access is enabled, the KubeDB Kafka operator mounts
external-listeners.propertiesinto the temp config dir, with one<pod-name>=EXTERNAL://<address>:<port>line per broker. The kafka-initsetup.shused by 4.x already appends the pod's line toadvertised.listeners. This ports the same block to the entrypoint baked into the 3.x images, so external access also works on 3.x.The same commit is opened against release-3.5.2, 3.6.1, 3.7.2, 3.8.1 and 3.9.0.
The webhook currently rejects
brokerservice templates on Kafka before 4.0.0; relaxing that is a separate change in kubedb/apimachinery.Testing, on a k3s cluster with MetalLB, using images built from this change:
EXTERNALaddress, and a client outside the cluster produced and consumed 100 messages through the primary LoadBalancer.