Repository navigation
Remove per-type imports in generated files - #981
Merged
Merged
Conversation
…ot yet supported in module interfaces" warning
Contributor
|
A net-negative LOC PR, I love it. Thanks, @JonathanDowning 🙏 |
czechboy0
approved these changes
Nov 4, 2026
czechboy0
enabled auto-merge (squash)
November 4, 2026 20:19
czechboy0
changed the title
czechboy0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The generator emits scoped Foundation imports (
import struct Foundation.URL,.Data,.Date). The compiler warns about these whenever it emits a module interface (scoped imports are not yet supported in module interfaces). The scoping was only there to track@preconcurrencysendability (#114),@preconcurrencywas removed in #969.Modifications
moduleTypesfromImportDescriptionand the renderer, along with its test.Result
Generated code has a single
import Foundation(with the configured access modifier, e.g.package import Foundation) and no longer triggers the warning.Test Plan
swiftc -enable-library-evolution -emit-module-interface-pathon scopedpublic,packageand plain imports. A whole-modulepackage import Foundationcompiles cleanly.swift test: All suites pass (0 failures)