Repository navigation
Make AsyncDNSResolver Sendable - #82
Merged
Merged
Conversation
hamzahrmalik
changed the title
hamzahrmalik
marked this pull request as ready for review
April 7, 2026 15:44
FranzBusch
reviewed
Apr 8, 2026
| /// API for running DNS queries. | ||
| @available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *) | ||
| public protocol DNSResolver { | ||
| public protocol DNSResolver: Sendable { |
Member
There was a problem hiding this comment.
This needs a @preconcurrency added
FranzBusch
approved these changes
Apr 8, 2026
FranzBusch
enabled auto-merge (squash)
April 8, 2026 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying dns resolvers are already sendable, so let's make AsyncDNSResolver sendable too