[OpenExec] Add ExecUsdSystemWrapper to expose ExecUsdSystem to Swift#32
Open
furbytm wants to merge 1 commit into
Open
[OpenExec] Add ExecUsdSystemWrapper to expose ExecUsdSystem to Swift#32furbytm wants to merge 1 commit into
furbytm wants to merge 1 commit into
Conversation
maddyadams
reviewed
Jul 1, 2026
maddyadams
reviewed
Jul 1, 2026
furbytm
force-pushed
the
feat/exec-usdsystem-wrapper
branch
from
fce9c05 to
b75308a
Compare
maddyadams
reviewed
Jul 1, 2026
maddyadams
left a comment
maddyadams
left a comment
Contributor
There was a problem hiding this comment.
LGTM (though I want to see what the Release crash apple/SwiftUsd-Tests#13 ends up being before I officially sign off on this)
Author
I went and fixed the tests so that Release builds don't crash for the test cases, along with the other requested changes. |
furbytm
force-pushed
the
feat/exec-usdsystem-wrapper
branch
from
b75308a to
035d1c2
Compare
Author
|
@maddyadams I made the changes to add the new closure design you asked for here in this PR, and updated the corresponding tests in apple/SwiftUsd-Tests#13 |
furbytm
force-pushed
the
feat/exec-usdsystem-wrapper
branch
2 times, most recently
from
6a3c4fa to
a1d038c
Compare
Introduce ExecUsdSystemWrapper to wrap the underlying OpenUSD ExecUsdSystem type to Swift. Resolves apple#31 Signed-off-by: Furby™ <furby@wabi.foundation>
furbytm
force-pushed
the
feat/exec-usdsystem-wrapper
branch
from
a1d038c to
1fe5ee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
ExecUsdSystemWrapperto expose the underlying OpenUSDExecUsdSystemtype to Swift.Related Issues / PRs
Checklist
CONTRIBUTING.mdPackage.swift/swift-package) from the commit