test: Fix flaky integration tests asserting membership in capped iterate()#824
Open
vdusek wants to merge 3 commits into
Open
test: Fix flaky integration tests asserting membership in capped iterate()#824vdusek wants to merge 3 commits into
vdusek wants to merge 3 commits into
Conversation
Drop the limit=10 cap so the iterator walks all of the user's queues; under the parallel integration suite, other tests creating queues concurrently could push the just-created ones past the 10-newest window and the inclusion assertion would fail.
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 48 48
Lines 4929 4929
=======================================
Hits 4661 4661
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several
*_collection_iterateintegration tests created a few resources, callediterate(limit=10, desc=True), and asserted each just-created ID showed up.limitis a total cap, not a per-page size — under the parallel suite, other workers creating the same resource type could push the fresh items past the 10-newest window before the assertion ran.Dropping
limit=10lets the iterator walk the full collection (server-side pagination still chunks the requests), so the inclusion check runs against the full set instead of a racy window.Failing CI runs