Skip to content

chore: shorten the Windows temp-disk comment #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladfrangu merged 1 commit into from
Sep 7, 2026
+8 −36
Merged

chore: shorten the Windows temp-disk comment #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/test_llm_ai_node_templates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,8 @@ jobs:
timeout-minutes: 30

steps:
# The Windows runners have two disks: C: is the network-backed Azure OS disk,
# D: is host-local SSD. RUNNER_TEMP and the workspace are on D:, but TEMP/TMP
# default to C:\Users\...\AppData\Local\Temp — and the harness installs every
# template under os.tmpdir(). Measured in #907, 10k small files in a
# node_modules-shaped tree: C: managed 744-1140 files/s against D:'s 4295-6008,
# and 55-202 MB/s against D:'s 1012-1365 on a bulk write. Moving the harness cut
# the Windows legs from a 12.1-15.3m mean to 6.7m, worst leg 24.3m -> 9.7m.
# Harmless on Linux, where both paths are on one disk.
# Set from a step because the `runner` context is not available in job-level env.
# The harness installs templates under os.tmpdir(); on Windows that is the
# network-backed C: disk, ~5x slower at small files than D: (RUNNER_TEMP). #907
- name: Install templates on the runner's fast disk
shell: bash
run: |
Expand Down
11 changes: 2 additions & 9 deletions .github/workflows/test_llm_ai_python_templates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,8 @@ jobs:
timeout-minutes: 30

steps:
# The Windows runners have two disks: C: is the network-backed Azure OS disk,
# D: is host-local SSD. RUNNER_TEMP and the workspace are on D:, but TEMP/TMP
# default to C:\Users\...\AppData\Local\Temp — and the harness installs every
# template under os.tmpdir(). Measured in #907, 10k small files in a
# node_modules-shaped tree: C: managed 744-1140 files/s against D:'s 4295-6008,
# and 55-202 MB/s against D:'s 1012-1365 on a bulk write. Moving the harness cut
# the Windows legs from a 12.1-15.3m mean to 6.7m, worst leg 24.3m -> 9.7m.
# Harmless on Linux, where both paths are on one disk.
# Set from a step because the `runner` context is not available in job-level env.
# The harness installs templates under os.tmpdir(); on Windows that is the
# network-backed C: disk, ~5x slower at small files than D: (RUNNER_TEMP). #907
- name: Install templates on the runner's fast disk
shell: bash
run: |
Expand Down
11 changes: 2 additions & 9 deletions .github/workflows/test_node_templates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,8 @@ jobs:
PUPPETEER_CACHE_DIR: ${{ github.workspace }}/.puppeteer-cache

steps:
# The Windows runners have two disks: C: is the network-backed Azure OS disk,
# D: is host-local SSD. RUNNER_TEMP and the workspace are on D:, but TEMP/TMP
# default to C:\Users\...\AppData\Local\Temp — and the harness installs every
# template under os.tmpdir(). Measured in #907, 10k small files in a
# node_modules-shaped tree: C: managed 744-1140 files/s against D:'s 4295-6008,
# and 55-202 MB/s against D:'s 1012-1365 on a bulk write. Moving the harness cut
# the Windows legs from a 12.1-15.3m mean to 6.7m, worst leg 24.3m -> 9.7m.
# Harmless on Linux, where both paths are on one disk.
# Set from a step because the `runner` context is not available in job-level env.
# The harness installs templates under os.tmpdir(); on Windows that is the
# network-backed C: disk, ~5x slower at small files than D: (RUNNER_TEMP). #907
- name: Install templates on the runner's fast disk
shell: bash
run: |
Expand Down
11 changes: 2 additions & 9 deletions .github/workflows/test_python_templates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,8 @@ jobs:
timeout-minutes: 30

steps:
# The Windows runners have two disks: C: is the network-backed Azure OS disk,
# D: is host-local SSD. RUNNER_TEMP and the workspace are on D:, but TEMP/TMP
# default to C:\Users\...\AppData\Local\Temp — and the harness installs every
# template under os.tmpdir(). Measured in #907, 10k small files in a
# node_modules-shaped tree: C: managed 744-1140 files/s against D:'s 4295-6008,
# and 55-202 MB/s against D:'s 1012-1365 on a bulk write. Moving the harness cut
# the Windows legs from a 12.1-15.3m mean to 6.7m, worst leg 24.3m -> 9.7m.
# Harmless on Linux, where both paths are on one disk.
# Set from a step because the `runner` context is not available in job-level env.
# The harness installs templates under os.tmpdir(); on Windows that is the
# network-backed C: disk, ~5x slower at small files than D: (RUNNER_TEMP). #907
- name: Install templates on the runner's fast disk
shell: bash
run: |
Expand Down
Loading