Fix handling of corrupted msgs to avoid crash - #441
Merged
Conversation
This adds handling of non-ASCII message bodies, which usually indicate a corrupted message, so that the message can be written out to the reject queue and avoid the receiver crashing. The altered code has been moved within the try...except (IOError, OSError) so that the new dirq add() is protected. Also add a unit test to cover the new code.
tofu-rocketry
force-pushed
the
corrupted-msgs
branch
from
August 18, 2026 11:25
c03cb12 to
34c3162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves GT-1642
This adds handling of non-ASCII message bodies, which usually indicate a corrupted message, so that the message can be written out to the reject queue and avoid the receiver crashing. The altered code has been moved within the try...except (IOError, OSError) so that the new dirq add() is protected.
Also add a unit test to cover the new code.