add broker config options for sql log redaction#18604
Conversation
|
i accidentally broke #18430. @xiangfu0 @Jackie-Jiang anymore comments on this? I want to avoid more conflicts since this touches so many lines |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18604 +/- ##
============================================
+ Coverage 56.82% 64.36% +7.54%
- Complexity 7 1137 +1130
============================================
Files 2567 3336 +769
Lines 149066 206158 +57092
Branches 24103 32149 +8046
============================================
+ Hits 84700 132690 +47990
- Misses 57178 62802 +5624
- Partials 7188 10666 +3478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The SQL redaction pass still appears incomplete for the single-stage RLS path. |
This adds a new feature to support query redaction. By default, query logs are not redacted.
With
literal_values, we use the the query fingerprint to only log the redacted query with no literal values. This is useful if folks still want the structure of the query without potentially leaking PII.This also fixes a bug where query fingerprinting was modifying the AST in place and breaking queries. This closes #18426.this was fixed yesterday in a better way.
The final option is full redaction. This is good if you want no SQL ending up in your logging system.
I tested all options internally on a QA cluster. We plan to stick with
fullredaction going forward.