Repository navigation
Conversation
Resolve the S3 volume through S3ClientProtocol and reuse abortMultipartUpload for multipart abort requests. Preserve OM version fallback and cached volume handling, with client and S3 Gateway regression coverage. Co-authored-by: Codex (GPT-6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Route multipart upload abort through
S3ClientProtocoland the existingabortMultipartUploadAPI, removing the separateabortS3MultipartUploadmethod.This centralizes S3 volume resolution in
S3ClientProtocol, preserves client-sideresolution for older OMs, and reuses the cached volume when a bucket lookup has
already occurred.
Add regression coverage for OM version compatibility, explicit volume handling,
bucket lookups, argument validation, and S3 error mapping.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17485
How was this patch tested?
https://github.com/hevinhsu/ozone/actions/runs/44479575428
Generated-by: Codex (GPT-6.1)