Skip to content

HDDS-17854. Show Maven transfer progress - #12086

Open
adoroszlai wants to merge 3 commits into
apache:masterfrom
adoroszlai:HDDS-17854
Open

adoroszlai wants to merge 3 commits into
apache:masterfrom
adoroszlai:HDDS-17854

Conversation

@adoroszlai

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Requests to Maven Central are rate-limited, and builds/tests intermittently fail due to download failures. To understand what is being downloaded, enable display of transfer progress.

get_version still prints the requested version property value to stdout, and regular output goes to stderr (but only in CI, because the command needs to be run twice).

actions/setup-java adds the -ntp option (== --no-transfer-progress) by default, so once we don't need the output, we can disable it for CI by a one-line change in setup-java-with-cache.

https://issues.apache.org/jira/browse/HDDS-17854

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/44306536135

Examples:

[INFO] --- pmd:3.28.0:pmd (pmd) @ ozone-dev-support ---
...
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/skins/maven-fluido-skin/2.0.0-M9/maven-fluido-skin-2.0.0-M9.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/skins/maven-fluido-skin/2.0.0-M9/maven-fluido-skin-2.0.0-M9.jar (355 kB at 7.6 MB/s)
[INFO] --- compiler:3.16.0:compile (default-compile) @ ozone-main ---
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/com/google/errorprone/error_prone_core/2.42.0/error_prone_core-2.42.0.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/com/google/errorprone/error_prone_core/2.42.0/error_prone_core-2.42.0.pom (18 kB at 419 kB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/com/google/errorprone/error_prone_parent/2.42.0/error_prone_parent-2.42.0.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/com/google/errorprone/error_prone_parent/2.42.0/error_prone_parent-2.42.0.pom (16 kB at 995 kB/s)
...

@adoroszlai adoroszlai added the CI label Nov 18, 2026
@adoroszlai adoroszlai self-assigned this Nov 18, 2026

@chihsuan chihsuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! @adoroszlai

get_version still prints the requested version property value to stdout, and regular output goes to stderr (but only in CI, because the command needs to be run twice).

Would using help:evaluate -Doutput=<temp-file> and then printing the file to stdout work here? That might let us keep the transfer logs on stderr without running Maven twice.

@adoroszlai

Copy link
Copy Markdown
Contributor Author

Would using help:evaluate -Doutput=<temp-file> and then printing the file to stdout work here?

Good idea, updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants