Repository navigation
HDDS-17850. Fix duplicate directory object ID in TestOmDBInsightEndPoint legacy bucket test data - #12082
Open
ArafatKhan2198 wants to merge 2 commits into
Open
HDDS-17850. Fix duplicate directory object ID in TestOmDBInsightEndPoint legacy bucket test data#12082ArafatKhan2198 wants to merge 2 commits into
ArafatKhan2198 wants to merge 2 commits into
Conversation
…int legacy bucket test data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
TestOmDBInsightEndPoint, the Legacy bucket test data wrotedir7(pathdir4/dir7/) with the name and object ID ofdir4(DIR_FOUR_OBJECT_ID, 21). As a result, two different directories shared the same object ID.This PR gives
dir7its own name (DIR_SEVEN) and a new object ID constant,DIR_SEVEN_OBJECT_ID = 42L. IDs 20-41 are already in use, so 42 is the next free one.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17850
How was this patch tested?
Ran
TestOmDBInsightEndPointlocally. All 40 tests pass with no changes to expected values. Checkstyle is clean.