Repository navigation
HDDS-17528. Make CreateBucket and SetBucketProperty ZDU compliant - #12080
Draft
anuragp010 wants to merge 1 commit into
Draft
anuragp010 wants to merge 1 commit into
anuragp010 wants to merge 1 commit into
Conversation
Contributor
Author
|
Please review @devmadhuu , @ArafatKhan2198 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CreateBucketandSetBucketPropertyrequests that carry storage policy fields must be rejected on the client side when theomVersiondoes not support storage policy. The OM already rejects such requests through its request validators, but the client side gate was missing. An OM binary older than the feature ignores the unknown protobuf fields, so the request would succeed with the policy silently dropped.This PR adds the client side gate in
RpcClient:createBucketand bothsetBucketStoragePolicyoverloads now throwIOException("OzoneManager does not support storage policy")whenSTORAGE_POLICY_SUPPORT.isSupportedBy(omVersion)is false.createBucketis gated only when a policy field is set, so clients that set none keep working.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17528
How was this patch tested?
TestRpcClientTestOMStoragePolicyUpgradeGenerated with: Claude Code