Fix record reformatting for alternative brace positioning.#9480
Open
neilcsmith-net wants to merge 1 commit into
Open
Fix record reformatting for alternative brace positioning.#9480neilcsmith-net wants to merge 1 commit into
neilcsmith-net wants to merge 1 commit into
Conversation
Fix reformatting of records with alternative brace positioning - make sure continuation flag not set. Adapt empty record formatting to work the same across all brace position settings.
neilcsmith-net
added
the
Java
matthiasblaesing
approved these changes
Jul 4, 2026
matthiasblaesing
left a comment
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
Looks sane to me and a quick test worked for me as expected. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix reformatting of records with alternative brace positioning - make sure continuation flag is not set, which caused the additional brace indentation.
Adapt empty record formatting to work the same across all brace position settings by checking for
{}and rolling back if not empty.Follow up to #9421 addressing issues that were not fixed there.
Removed the
try / finallysections as just made this harder to fix without necessarily doing anything useful here.