[DIRMINA-1146] Pass message to next filter in SslFilter - #61
Draft
the-thing wants to merge 2 commits into
Draft
Conversation
Contributor
|
Hi, thanks for the proposed patch. I'm not sure it's related, but I don't have this failure when I don't apply your proposed patch. I have tested with Java 17 and 25. If I run the exact same class test in eclipse, it passes green... Go fish... I'm trying to see what could be the cause of this issue (beside the fact the connection has been closed) |
Author
|
Hello, I was getting slightly different error for Windows 11 / temurin / Java 17 I also consistently get an error on 2.2.x
Let me have a look as well. |
the-thing
marked this pull request as draft
September 9, 2026 16:10
Contributor
|
I also have the same issue with the NPE when the message is sent back to the IoHandler. Now to understand why the socket has been closed... |
Contributor
|
ok, I think the issue is on the client side. On the server, the connection get closed by the client thus it can't return anything to the client. I still have no idea why the client closes the connection, I keep digging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DIRMINA-1146
It will also help fix quickfix-j/quickfixj#406
Changes
Currently none of the
EncryptedWriteRequestinstances have parent message provided which means that original message and request is always the same instance. We must pass all the messages down the chain.org.apache.mina.filter.ssl.SslFilternow also passes the encrypted message down the filter chain, eventually reachingorg.apache.mina.core.filterchain.DefaultIoFilterChain.TailFilterwhich will increase the written message count and also decrement scheduled message count.Obviously this change will have an impact filters configured between
org.apache.mina.filter.ssl.SslFilterandorg.apache.mina.core.filterchain.DefaultIoFilterChain.TailFilter, but I think users should make changes accordingly in this case.