feat(bdd): unify rust image versions to slim-trixie#3569
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
|
do you think that it woudl be worth to add some machinery that would sync / check if its synced? maybe either reuse |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3569 +/- ##
=============================================
- Coverage 74.02% 48.25% -25.77%
Complexity 937 937
=============================================
Files 1247 1246 -1
Lines 127567 111705 -15862
Branches 103436 87618 -15818
=============================================
- Hits 94427 53907 -40520
- Misses 30104 54997 +24893
+ Partials 3036 2801 -235
🚀 New features to boost your workflow:
|
|
/ready |
| # fully endorsed by the ASF. | ||
|
|
||
| FROM mcr.microsoft.com/devcontainers/python:1-3.10-bullseye | ||
| FROM mcr.microsoft.com/devcontainers/python:1-3.10-trixie |
There was a problem hiding this comment.
this version does not exists, you can use 3.10-trixie instead
There was a problem hiding this comment.
To be honest, I was wondering whether a dev container is really required for python? This is the only folder that has a dev container, as far as I can tell, and currently, we use uv to manage all python versions and dependencies. I was thinking it would be better to delete this. What do you think?
There was a problem hiding this comment.
I haven't used it for a while now, not sure if anyone else is using it. Yeah, with uv that should be easier anyway than when I created this dev container. Anyways, I'm OK with dropping it
There was a problem hiding this comment.
I think this file got stale, and it's no longer in use and can be removed. The docker-compose files reference Dockerfile from core/server directly. @hubcio correct me if I'm wrong
Otherwise, switching from alpine to debian would require some commands changes.
|
/author |
Changes rust-based images to slim-trixie version.
As an aside, there are a variety of versions (bookworm, bookworm-slim, trixie, trixie-slim, alpine) being used throughout the repo. Maybe it would be better to choose one version and utilize that everywhere?