Skip to content

feat(bdd): unify rust image versions to slim-trixie#3569

Open
slbotbm wants to merge 5 commits into
apache:masterfrom
slbotbm:bdd-docker-corrections
Open

feat(bdd): unify rust image versions to slim-trixie#3569
slbotbm wants to merge 5 commits into
apache:masterfrom
slbotbm:bdd-docker-corrections

Conversation

@slbotbm

@slbotbm slbotbm commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Changes rust-based images to slim-trixie version.

As an aside, there are a variety of versions (bookworm, bookworm-slim, trixie, trixie-slim, alpine) being used throughout the repo. Maybe it would be better to choose one version and utilize that everywhere?

@github-actions

Copy link
Copy Markdown

Thanks for the PR. It is labeled S-waiting-on-review and queued for review.

Slash commands (own line, regular comment) move it around the queue:

  • /ready - back to S-waiting-on-review after addressing feedback
  • /author - flip to S-waiting-on-author while you finish changes
  • /request-review @user-or-team - request a reviewer

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Jun 26, 2026
@slbotbm slbotbm changed the title bdd: unify rust image versions to slim-trixie feat(bdd): unify rust image versions to slim-trixie Jun 26, 2026
@hubcio

hubcio commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

do you think that it woudl be worth to add some machinery that would sync / check if its synced? maybe either reuse sync-rustc-version.sh or a new script

Comment thread bdd/java/Dockerfile Outdated
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.25%. Comparing base (8c1fefb) to head (4002413).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3569       +/-   ##
=============================================
- Coverage     74.02%   48.25%   -25.77%     
  Complexity      937      937               
=============================================
  Files          1247     1246        -1     
  Lines        127567   111705    -15862     
  Branches     103436    87618    -15818     
=============================================
- Hits          94427    53907    -40520     
- Misses        30104    54997    +24893     
+ Partials       3036     2801      -235     
Components Coverage Δ
Rust Core 41.58% <ø> (-33.09%) ⬇️
Java SDK 62.44% <ø> (ø)
C# SDK 71.40% <ø> (-0.71%) ⬇️
Python SDK 88.88% <ø> (ø)
PHP SDK 84.29% <ø> (ø)
Node SDK 91.35% <ø> (+0.12%) ⬆️
Go SDK 40.14% <ø> (ø)
see 359 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slbotbm

slbotbm commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Jun 26, 2026
# fully endorsed by the ASF.

FROM mcr.microsoft.com/devcontainers/python:1-3.10-bullseye
FROM mcr.microsoft.com/devcontainers/python:1-3.10-trixie

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version does not exists, you can use 3.10-trixie instead

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I was wondering whether a dev container is really required for python? This is the only folder that has a dev container, as far as I can tell, and currently, we use uv to manage all python versions and dependencies. I was thinking it would be better to delete this. What do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used it for a while now, not sure if anyone else is using it. Yeah, with uv that should be easier anyway than when I created this dev container. Anyways, I'm OK with dropping it

Comment thread bdd/Dockerfile

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file got stale, and it's no longer in use and can be removed. The docker-compose files reference Dockerfile from core/server directly. @hubcio correct me if I'm wrong
Otherwise, switching from alpine to debian would require some commands changes.

@mmodzelewski

Copy link
Copy Markdown
Member

/author

@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author PR is waiting on author response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants