-
Notifications
You must be signed in to change notification settings - Fork 86
feat: add bounded graph extraction concurrency #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3719fb3
fd572e3
182e1a3
5e3ac82
fea7c35
e80f434
43d9bd6
8f43b44
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,6 +79,7 @@ class BasePromptConfig: | |
| gremlin_generate_prompt: str = "" | ||
| doc_input_text: str = "" | ||
| graph_extract_split_type: str = "document" | ||
| graph_extract_max_workers: int = 1 | ||
| schema_generator_query_examples: str = "" | ||
| schema_generator_few_shot_examples: str = "" | ||
| _language_generated: str = "" | ||
|
|
@@ -140,6 +141,7 @@ def to_literal(val): | |
| "gremlin_generate_prompt": to_literal(self.gremlin_generate_prompt), | ||
| "doc_input_text": to_literal(self.doc_input_text), | ||
| "graph_extract_split_type": to_literal(self.graph_extract_split_type), | ||
| "graph_extract_max_workers": self.graph_extract_max_workers, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| "schema_generator_query_examples": to_literal(self.schema_generator_query_examples), | ||
| "schema_generator_few_shot_examples": to_literal(self.schema_generator_few_shot_examples), | ||
| "_language_generated": str(self.llm_settings.language).lower().strip(), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 REST validation coerces some raw inputs before the shared validator can enforce its contract. A direct probe shows
graph_extract_max_workers=trueand"1.0"are both accepted here as integer1, whilevalidate_graph_extract_max_workers()rejects those same raw values. This makes REST behavior inconsistent with the flow/helper entry points and can silently turn malformed input into a valid request. Please add amode="before"field validator (or equivalent strict raw-input validation) that applies the shared rules, and cover boolean and decimal-string request values with regression tests.