Keep FastDateParser numeric parse from throwing on int overflow#1741
Merged
garydgregory merged 1 commit intoJul 4, 2026
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: parse an untrusted date whose numeric field is a digit run that overflows
int, e.g.FastDateFormat.getInstance("yyyy").parse("99999999999"), orgetInstance("yyyy").parseObject("99999999999", new ParsePosition(0)).Cause:
NumberStrategy.parsescans an unbounded run of digits for a trailing or standalone numeric field (itsmaxWidthis0) and passes the whole run toInteger.parseInt. A run that overflowsintmakesparseIntthrowNumberFormatException, which escapes uncaught, soparse(String)throwsNumberFormatExceptionrather than the declaredParseException, and theParsePositionoverloads (parse,parseObject) throw instead of returningnullwith an error index as thejava.text.Formatcontract requires.Fix: catch the overflow inside
NumberStrategy.parseand signal a parse failure the same way the existing empty-digit branch already does (setErrorIndexthen returnfalse), so the field is simply unparseable instead of crashing the parser. Valid inputs are unchanged and it is the onlyInteger.parseIntin the class.