Stop ExtendedMessageFormat seekNonWs reading past the pattern end#1740
Merged
Conversation
Member
|
Hello @dxbjavid , merged 🚀 TY! |
Contributor
Author
|
Thank you @garydgregory for the review and merge. I appreciate your guidance in porting the fix from Commons Text to Commons Lang. Glad to contribute, and thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of apache/commons-text#759 to the equivalent org.apache.commons.lang3.text.ExtendedMessageFormat.
The registry-based ExtendedMessageFormat constructor parses its pattern with seekNonWs, which asks the split matcher about the character at the current parse index without first checking it is still inside the buffer. A truncated format element such as {, {0, or trailing text like {0}extra{ leaves the parse position at the end of the pattern, so the matcher reads one past the char array and the constructor throws ArrayIndexOutOfBoundsException rather than the documented IllegalArgumentException that the plain constructor already gives for the same input.
This bounds the seek to the pattern length so those patterns report the usual unterminated-format-element error. A regression test covers the three shapes above, alongside the JRE sanity checks you added post-merge on the commons-text side.