[CELEBORN-2381] Authorize PbApplicationMetaRequest to prevent secret disclosure#3759
Closed
SteNicholas wants to merge 1 commit into
Closed
[CELEBORN-2381] Authorize PbApplicationMetaRequest to prevent secret disclosure#3759SteNicholas wants to merge 1 commit into
SteNicholas wants to merge 1 commit into
Conversation
…disclosure The Master served PbApplicationMetaRequest by returning the requested application's SASL secret without an authorization check, unlike the other application-scoped handlers (RequestSlots, UnregisterShuffle, ApplicationLost). With authentication enabled, a caller on the external application port could read another application's secret and impersonate it. Call checkAuth(context, appId) before serving the request, consistent with the sibling handlers. Workers fetch application meta over the internal channel, where the connection has no per-application client id, so the check is a no-op for them.
SteNicholas
force-pushed
the
CELEBORN-2381
branch
from
56db6f9 to
7fc3278
Compare
Kalvin2077
reviewed
Jul 14, 2026
Kalvin2077
approved these changes
Jul 14, 2026
RexXiong
approved these changes
Jul 14, 2026
Contributor
|
Merge to main(v0.7.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Call
checkAuth(context, appId)before servingPbApplicationMetaRequestin the Master, consistent with the other application-scoped handlers (RequestSlots,UnregisterShuffle,ApplicationLost).Workers fetch application meta over the internal channel, where the connection has no per-application client id, so the check is a no-op for them; it only rejects an external application that asks for another application's secret.
Why are the changes needed?
The Master served
PbApplicationMetaRequestby returning the requested application's SASL secret without an authorization check. With authentication enabled, a caller on the external application port could read another application's secret and impersonate it.Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
MasterApplicationMetaAuthSuiteverifyingPbApplicationMetaRequestis authorized against the registered application.MasterSuiteverifying a caller requesting another application's secret is rejected.