[CELEBORN-2379] Keep sbt and maven dependency lists in sync and cross-check both in CI#3757
Open
cxzl25 wants to merge 2 commits into
Open
[CELEBORN-2379] Keep sbt and maven dependency lists in sync and cross-check both in CI#3757cxzl25 wants to merge 2 commits into
cxzl25 wants to merge 2 commits into
Conversation
cxzl25
commented
Jul 10, 2026
|
|
||
| # Explicitly set locale in order to make `sort` output consistent across machines. | ||
| # See https://stackoverflow.com/questions/28881 for more details. | ||
| export LC_ALL=C |
Contributor
Author
There was a problem hiding this comment.
The way this global environment variable is written may cause some character exceptions to be displayed during Java compilation.
Main
CelebornFlinkShim.java:23:38: ??: ????Tuple2
[WARNING] javac exited with exit code 1
PR
CelebornFlinkShim.java:23:38: 错误: 无法访问Tuple2
[WARNING] javac exited with exit code 1
cxzl25
commented
Jul 10, 2026
| // no-op there. Gate it to JDK 8 to match the `JDKTools` plugin | ||
| // (project/JDKTools.scala) and the Maven `jdk-8` profile, and to keep the | ||
| // sbt/maven classpaths in sync (see dev/dependencies.sh). | ||
| libraryDependencies ++= |
Contributor
Author
There was a problem hiding this comment.
If Flink2.3 uses sbt, it will bring additional maven-jdk-tools-wrapper dependency, which is wrong. This issue is fixed here.
cxzl25
commented
Jul 10, 2026
| ./dev/dependencies.sh ${{ matrix.tool == 'sbt' && '--sbt' || '' }} --module ${{ matrix.module }} --check | ||
|
|
||
| maven-jdk11: | ||
| jdk11: |
Contributor
Author
There was a problem hiding this comment.
jdk11 jdk17 does not use sbt check, so some dependencies fail in sbt, here use matrix to reduce some duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
GHA