Repository navigation
ai - the LangChain4j chat model is configured by provider instead of a bean of the model class - #128
Merged
Merged
Conversation
…p-server and contracts/openapi-server use what it brings CI pins Camel 4.23.0 for the CLI and for the integrations the Citrus tests start, as camel@apache/camel defaults to the latest LTS release (4.22.0). ai/mcp-server sets the server title, description and instructions, its README says that the server serves ai-resource routes next to the tools, and the log lines it shows are those of 4.23.0. contracts/openapi-server keeps its /api base path, but its README no longer says the servers entry must have a path: on 4.23 an entry without one serves the operations at the root. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
…assifier writes at runtime The catalog was generated in a directory where the example had run, so it listed tickets-out/*/T-*.json, which are not in the repository; fetching them from GitHub answers 404. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
…a bean of the model class Camel 4.23 creates the langchain4j-chat model from a provider and the options every provider has (CAMEL-24820), and camel run downloads the provider's LangChain4j module. ai/langchain4j-chat and ai/ticket-classifier set provider, baseUrl, modelName and temperature on the endpoint, so their Citrus tests, which pass only the URL and the model name, need no change. ai/docling-langchain4j-rag (four endpoints) and security/ocsf set them as component options in application.properties. The OllamaChatModel builder beans are gone, and the READMEs, the log line numbers they show and the catalog descriptions say the model is configured by provider. Closes #91. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91. Stacked on #126; retarget to
mainonce that is merged.Camel 4.23 creates the
langchain4j-chatmodel from a provider (CAMEL-24820), andcamel rundownloads the provider's LangChain4j module, so theOllamaChatModelbuilder beans go:provider: ollama,baseUrl,modelNameandtemperatureon the endpoint. Their Citrus tests pass onlyollama.base.urlandollama.model, notapplication.properties, so options on the endpoint keep the tests unchanged.camel.component.langchain4j-chat.provider=ollamaand friends inapplication.properties.provider=openaiand anapi-key. The "Using OpenAI instead of Ollama" section with the Groovy bean, mentioned in the issue, was already gone.Since the issue was filed, #93 and #103 brought the bean back in the RAG and OCSF examples, so they were no longer broken; this replaces those beans too. ai/ticket-classifier was added after the issue (#119) and gets the same change.
Tested locally with Camel 4.23.0 against a local Ollama (granite4:3b):
application.properties, as its Citrus test runs it./api/ocsf/detection-finding/summarizeanswers with the model's summary.camel validate yaml --canonicalsucceeds for all four route files.I did not run the two Citrus tests: they start their own Ollama container and pull a 2.5 GB model.
Claude Code on behalf of davsclaus
🤖 Generated with Claude Code