Skip to content

[AURON #2323] Refactor and rename cast test suites for ANSI mode on and off#2324

Open
cxzl25 wants to merge 1 commit into
apache:masterfrom
cxzl25:auron_2323
Open

[AURON #2323] Refactor and rename cast test suites for ANSI mode on and off#2324
cxzl25 wants to merge 1 commit into
apache:masterfrom
cxzl25:auron_2323

Conversation

@cxzl25

@cxzl25 cxzl25 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #2323

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

How was this patch tested?

GHA

@weiqingy weiqingy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on — the rename correctly tracks Spark 4's base-class refactor: extending CastWithAnsiOnSuite/CastWithAnsiOffSuite and dropping the AuronAnsiCast*WithAnsiMode* wrappers (Spark 4 folded the standalone AnsiCast path into Cast, so those base classes no longer exist) is the right mapping, and CI confirms both modules now compile past #2323. One question on the overall check state.

  1. The spark-4.0 and spark-4.1 checks are still red on the latest run, but they now fail in the scalatest phase rather than at compile — so the rename did its job: both modules reach scala-test-compile and run the suites. The remaining failures are in other suites in the auron-spark-tests-spark40/41 modules that only surface now that the module compiles — AuronTryCastSuite and the parquet/JSON read suites hit TASK_WRITE_FAILED and RemoteClassLoaderError: org.apache.spark.sql.catalyst.expressions.Object, alongside native panics like map_from_arrays does not support null map keys. The two renamed cast suites themselves run with every case reported !!! IGNORED !!!, so they aren't the cause. Is the intent here to unblock compilation while those Spark 4 runtime failures are tracked separately? If so, would it be worth a line in the description noting spark-4.0/4.1 will stay red pending those follow-ups, so it's clear the check isn't expected to go green with this merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Spark4 not found: type AnsiCastSuite

2 participants