Repository navigation
fix(arrow-cast): reject leap seconds in time strings - #12286
Open
AmanBoronbaev wants to merge 1 commit into
Open
AmanBoronbaev wants to merge 1 commit into
AmanBoronbaev wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5335.
Rationale for this change
Arrow time types cannot represent leap seconds. Parsing
23:59:60currently produces a value outside the permitted time-of-day range, while08:08:60silently becomes the following minute.What changes are included in this PR?
Reject second
60in the time parser and reject Chrono's leap-second representation when parsing with an explicit format. Document this behavior onstring_to_time_nanoseconds.Are these changes tested?
Regression tests cover all four Time32/Time64 units, midnight and the last representable instant of the day, fractional leap seconds, AM/PM, surrounding whitespace, and explicit formats. The string-cast tests cover null-on-failure and strict errors for Utf8, LargeUtf8, and Utf8View inputs. The updated regression cases fail on the original implementation.
Fork CI passed, including the Arrow and Parquet test suites and cross-language integration.