Repository navigation
Add all-empty string case to the parquet arrow_writer benchmark - #12140
Merged
Merged
Conversation
`string_empty` writes one non-null Utf8 column with 1M empty values. Like `concat`, `take` and `interleave`, `from_iter_values` gives an all-empty array a values buffer without an allocation, so its pointer is dangling.
Rich-T-kid
reviewed
Nov 9, 2026
Rich-T-kid
left a comment
Contributor
There was a problem hiding this comment.
code makes sense, im a little puzzled as to what this benchmark would be used for though
Rich-T-kid
self-requested a review
November 14, 2026 03:07
Co-authored-by: RIchard Baah <137434454+Rich-T-kid@users.noreply.github.com>
Rich-T-kid
approved these changes
Nov 16, 2026
Contributor
|
@azecevic000 there is a CI failure in your fork |
Rich-T-kid
enabled auto-merge
November 16, 2026 14:16
Contributor
|
thanks @azecevic000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#12269
Rationale for this change
Benchmark for the case of a large empty buffer. There is a real regression in glibc >=2.35 on x86 AVX512.
What changes are included in this PR?
Just a benchmark case as recommended in
CONTRIBUTING.md.Are these changes tested?
Are there any significant user-facing changes?
No.
AI use
An AI coding agent wrote the code. I have reviewed it and verified the benchmark results.