Skip to content

[58_maintenance] fix(arrow-data): fix gaps in ListView equality - #11703

Merged
alamb merged 2 commits into
apache:58_maintenancefrom
Jefffrey:backport_11345_58
Oct 21, 2026
Merged

alamb merged 2 commits into
apache:58_maintenancefrom
Jefffrey:backport_11345_58

Conversation

@Jefffrey

Copy link
Copy Markdown
Contributor

- N/A

`list_view_equal` had two bugs:

* When both arrays had null rows, it compared each non-null row using
the size of the LHS only. For example, `[[1, 2], null]` was considered
equal to `[[1, 2, 3], null]`.
* Rows that differed only in their null masks were not handled
correctly: they were either incorrectly considered equal, or the
comparison resulted in a panic.

* Fix ListView equality bugs
* Add unit tests

Yes; existing tests pass, new tests added.

No.

Developed with Claude Code (Opus 5.5).
@github-actions github-actions Bot added the arrow-core Core crates related to representing arrow data label Oct 19, 2026
@Jefffrey Jefffrey added the bug label Oct 19, 2026
Jefffrey added a commit that referenced this pull request Oct 21, 2026
…oc, MIRI and integration test fixes (#11727)

# Which issue does this PR close?

- Part of #11665 (58.4.1 release)

# Rationale for this change

CI on the 58_maintenance branch is red on every PR (e.g. #11365, #11703,
#11704, #11705, #11707) for reasons unrelated to those PRs.



# What changes are included in this PR?

- Check in the root `Cargo.lock`, the same approach as
#9941
- Backport #11305: remove duplicate `homepage` entries and let rustdoc
infer the targets of five `arrow-avro` intra-doc links.
- Backport #10433: stop asserting on the unstable `TryFromIntError`
message in the `arrow-schema` tests.
- Backport #9888: support `ListView`, `BinaryView` and `RunEndEncoded`
in the integration test JSON parser.

# Are these changes tested?

Yes by CI

# Are there any user-facing changes?

No.

---------

Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Co-authored-by: Aditya Mishra <bit2swaz@gmail.com>
Co-authored-by: Dewey Dunnington <dewey@wherobots.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
Co-authored-by: Phoenix <Phoenix500526@163.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
@Jefffrey
Jefffrey marked this pull request as ready for review October 21, 2026 11:26
@alamb

alamb commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Merging as MSRV failure is unrelated. I will fix in this PR

@alamb
alamb merged commit bccaa42 into apache:58_maintenance Oct 21, 2026
26 of 27 checks passed
@Jefffrey
Jefffrey deleted the backport_11345_58 branch October 21, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow-core Core crates related to representing arrow data bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants