fix(compute): propagate nested expression serialization errors - #1160
Draft
fallintoplace wants to merge 1 commit into
Draft
fix(compute): propagate nested expression serialization errors#1160fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
marked this pull request as ready for review
August 9, 2026 22:51
fallintoplace
marked this pull request as draft
August 9, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
SerializeExpr ignores errors returned while visiting call arguments. A nested unsupported literal can therefore produce a successful result with incomplete metadata, and scalar columns allocated before the error are not released.
What changes are included in this PR?
Propagate errors from nested arguments and release all temporary scalar columns on both success and failure paths.
Are these changes tested?
Yes. The regression test places a valid scalar before an unsupported nested array literal and checks both the returned error and allocator cleanup. The full arrow/compute package suite passes.
Are there any user-facing changes?
Nested serialization failures are now returned to the caller instead of being silently ignored.