fix(parquet/encoding): honor BufferWriter offsets - #1144
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
marked this pull request as ready for review
August 8, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
BufferWritermixed logical positions with physical buffer offsets. This made reservations too small, placedUnsafeWriteCopyat the wrong location, truncated buffers afterUnsafeWrite, and applied the offset twice duringSeek.What changes are included in this PR?
Keep reservations, writes, length reporting, and seeking consistent with the configured offset. Add focused tests for regular writes, unsafe pattern writes, and seeking.
Are these changes tested?
go test ./parquet/internal/encodinggo test -race ./parquet/internal/encoding -run TestBufferWriterAre there any user-facing changes?
Parquet buffer writers now preserve the expected logical position and length when an offset is used.