Log ZooKeeper-backed property changes#6465
Conversation
|
I would suggest moving the logging to PropUtil, which is called from the ManagerClientServiceHandler for RPC calls, but also ZooPropEditor and a couple other places. It might be useful to add a commented-out logger configuration to the log4j-service.properties file like we do for the audit configuration too. |
|
I think we should target 2.1 for these changes. It'd be really useful to log this for troubleshooting existing deployments. |
I don't think it would be useful to do that. The commented out audit logger already serves as an example of how to do it for any other logger that the user chooses. We don't need multiple examples, as it adds noise and reduces readability of the default config that we ship. |
e8361b0 to
4fde965
Compare
I did this in 4fde965
Done. I'll make a follow on PR against main to add this feature for resource group logging once this PR is merged up. |
|
Here is updated output from the logs: and the corresponding shell session |
Fixes #6254
Adds INFO logging for property changes.
Here is some corresponding shell and logs: