Repository navigation
add #86494 transcode non-streamable audio to mp3 on make public - #141
Merged
Merged
Conversation
added 2 commits
August 31, 2026 09:36
A published 783 MB wav route bypassed CloudFlare's cacheable file size, so every listener streamed ~2.3 Mbps from origin and a scraper triggered network alerts on the cache servers. Audio whose mime is not publicly streamable (wav, x-wav) is now transcoded to mp3 128k when the public copy is written; the stored original stays untouched and browser-ready audio keeps its raw byte passthrough. Conversion target (extension + bitrate) lives on AudioMimeTypes next to the predicate. MakePublicAssetFileCommand creates the main public route for any asset file outside an HTTP request, needed to regenerate the existing production route (its URL extension changes from .wav to .mp3).
marforon
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A published 783 MB wav route bypassed CloudFlare's cacheable file size, so every listener streamed ~2.3 Mbps from origin and a scraper triggered network alerts on the cache servers.
Audio whose mime is not publicly streamable (wav, x-wav) is now transcoded to mp3 128k when the public copy is written; the stored original stays untouched and browser-ready audio keeps its raw byte passthrough. Conversion target (extension + bitrate) lives on AudioMimeTypes next to the predicate.
MakePublicAssetFileCommand creates the main public route for any asset file outside an HTTP request, needed to regenerate the existing production route (its URL extension changes from .wav to .mp3).