Skip to content

GO-7567: fail-point tests skip before setting mock expectations (fixes v0.7.0 release build) - #61

Merged
requilence merged 1 commit into
mainfrom
fix/release-failpoint-skip-before-mocks
Oct 6, 2026
Merged

requilence merged 1 commit into
mainfrom
fix/release-failpoint-skip-before-mocks

Conversation

@requilence

Copy link
Copy Markdown
Contributor

Summary

  • The v0.7.0 release build failed in TestCacheService_StalledTransactionIsBounded and TestCacheService_StalledLeaseWritesAreBounded: CI's Mongo replica set has no test commands, so failCommand skips — but gomock expectations set before it were then reported as missing calls.
  • Set the fail point (and thus the skip) before the expectations. Test-only change.

Failed run: https://github.com/anyproto/any-ns-node/actions/runs/37505001570

Test plan

  • Reproduced on a local replica set without test commands: main fails exactly these two tests; this branch passes ./cache/
  • Replica set with test commands: ./cache/ passes (fail-point tests run)
  • Release build green after re-tag (v0.7.1)

On a replica set without test commands (the CI Mongo) failCommand skips the test,
but the expectations set before it were reported as missing calls, failing the
v0.7.0 release build. Set the fail point first.
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

New Coverage 56.2% of statements
Patch Coverage 0.0% of changed statements (0/0)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@requilence
requilence merged commit ded2b34 into main Oct 6, 2026
8 checks passed
@requilence
requilence deleted the fix/release-failpoint-skip-before-mocks branch October 6, 2026 21:22
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant