Repository navigation
GO-7567: fail-point tests skip before setting mock expectations (fixes v0.7.0 release build) - #61
Merged
Conversation
On a replica set without test commands (the CI Mongo) failCommand skips the test, but the expectations set before it were reported as missing calls, failing the v0.7.0 release build. Set the fail point first.
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestCacheService_StalledTransactionIsBoundedandTestCacheService_StalledLeaseWritesAreBounded: CI's Mongo replica set has no test commands, sofailCommandskips — but gomock expectations set before it were then reported as missing calls.Failed run: https://github.com/anyproto/any-ns-node/actions/runs/37505001570
Test plan
./cache/./cache/passes (fail-point tests run)