Skip to content

Av/693 streamline login logout - #706

Merged
gjwgit merged 2 commits into
devfrom
av/693_streamline_login_logout
Aug 28, 2026
Merged

Av/693 streamline login logout#706
gjwgit merged 2 commits into
devfrom
av/693_streamline_login_logout

Conversation

@anushkavidanage

@anushkavidanage anushkavidanage commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Details

Description

  • Add prewarmSolidAuthenticate(): builds a SolidAuthManager, calls its new prewarm(), and caches it; solidAuthenticate() reuses that cached manager when serverId/clientId/redirectUri/oidcOptions all match, then clears the cache either way.
  • solidAuthenticate() gains an optional oidcOptions passthrough to SolidOidcConfig (defaults to null, no behaviour change) for callers who want to set package:oidc platform options directly.
  • Add oidc as a direct dependency (was already resolved transitively via solid_auth).

Why

Companion to the solid_auth PR: anusii/solid_auth#50 closes the gap where Safari/Brave silently blocks the login popup because window.open() fires after solidAuthenticate()'s WebID/issuer-discovery network round trips instead of synchronously with the click.

Related Issues

#693

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

Run the example app in corresponding branches of solidui with different Browser and OS combinations. See PR anusii/solidui#402 for more details.

Checklist

  • Screenshots included here/in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@gjwgit
gjwgit merged commit 24b6fe9 into dev Aug 28, 2026
16 of 20 checks passed
@gjwgit
gjwgit deleted the av/693_streamline_login_logout branch August 28, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants