Av/693 streamline login logout - #706
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
prewarmSolidAuthenticate(): builds aSolidAuthManager, calls its newprewarm(), and caches it;solidAuthenticate()reuses that cached manager whenserverId/clientId/redirectUri/oidcOptionsall match, then clears the cache either way.solidAuthenticate()gains an optionaloidcOptionspassthrough toSolidOidcConfig(defaults tonull, no behaviour change) for callers who want to setpackage:oidcplatform options directly.oidcas a direct dependency (was already resolved transitively viasolid_auth).Why
Companion to the solid_auth PR: anusii/solid_auth#50 closes the gap where Safari/Brave silently blocks the login popup because
window.open()fires aftersolidAuthenticate()'s WebID/issuer-discovery network round trips instead of synchronously with the click.Related Issues
#693
Type of Change
How To Test?
Run the example app in corresponding branches of
soliduiwith different Browser and OS combinations. See PR anusii/solidui#402 for more details.Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising