fix(types): more specific returns for app related enums#5248
Closed
Gobot1234 wants to merge 2 commits into
Closed
Conversation
Up to standards ✅🟢 Issues
|
mkundu1
reviewed
Jul 9, 2026
| def get_app_mode(self) -> Enum: | ||
| def get_app_mode(self) -> "FluentMode": | ||
| """Get app mode.""" | ||
| from ansys.fluent.core import FluentMode |
Collaborator
There was a problem hiding this comment.
@prmukherj Can we move these to global imports? I think we can import from ansys.fluent.core.launcher.launch_options to avoid any dependency issues coming from the top-level imports.
Collaborator
There was a problem hiding this comment.
yes, will do, Thanks. @Gobot1234, I will take care of this file.
auto-merge was automatically disabled
July 13, 2026 03:39
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed these weren't typed thought it would be useful to be more specific for typing+testing purposes