Repository navigation
ci: replace OpenCode app token on v1 with GITHUB_TOKEN - #59808
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate.ymlandnix-hashes.ymlon v1 fail withappId option is requiredbecauseOPENCODE_APP_IDandOPENCODE_APP_SECRETwere removed. This switches v1 to the same mechanism dev uses, which needs onlyGITHUB_TOKEN.Nix hashes: same as dev #59464
nix-hashes.ymlbecomesbot-nix-hashes.yml, copied from dev. Thehashandcomputejobs use a read-only token and no secrets.publish(contents,pull-requestsandactionswrite) runs only.github/nix-hashes/publish.shfrom the triggering commit. It commits only a validatednix/hashes.jsontobot/v1-nix-hashes, opens or updates the PR intov1, dispatchestypecheck.yml,test.yml,nix-eval.ymlandcheck-bot-scope.ymlon the branch, and runsgh pr merge --auto --squash.check-bot-scope.ymland.github/nix-hashes/validate.share copied from dev. The check failsbot/v1-nix-hashesunless it changes only a validnix/hashes.json.v1, the bot branch isbot/v1-nix-hashes, the path filters match v1 (noservices/*), and the concurrency group is v1-specific.Generate: same as dev
Dev removed its generate bot (15f0fc9) and checks generated files in pull requests instead.
generate.ymlis removed here, andtypecheck.ymlgets ageneratedjob. It runs./script/generate.ts(SDK build, OpenAPI and prettier) and fails if that changes anything. v1 is currently clean under it.Removed
generate.yml.docs-locale-sync.yml: it only triggers on pushes todev, and dev doesn't have this file, so it never runs.models-snapshot.yml: it is scheduled, so it runs from dev, where the file doesn't exist. It also targetsv2..github/actions/setup-git-committer.No v1 workflow references
OPENCODE_APP_ID,OPENCODE_APP_SECREToractions/create-github-app-tokenanymore.Before the bot can merge on v1 (ruleset 25933885, not changed here)
The
updaterule only lets bypass actors changev1, andgithub-actionsisn't one. Until that changes,publishopens or updates the PR, then fails atgh pr merge. The PR stays open for someone to merge.v1 also has no required status checks, so
check-bot-scopewouldn't gate auto-merge. Both changes are needed together:bot-scopecheck (GitHub Actions app, integration 15368) onrefs/heads/v1in a separate ruleset that has nogithub-actionsbypass. A bypass on 25933885 would also skip its own rules.bypass_mode: "pull_request", so it can only merge through a pull request.Auto-merge is already enabled for the repository.
Checks
blacksmith-*labels plus 2 findings, both in the deleteddocs-locale-sync.ymlandgenerate.yml. After: 24 unknown labels and nothing else.bash -npasses onpublish.shandvalidate.sh, andvalidate.shaccepts v1'snix/hashes.json../script/generate.tsleaves v1 unchanged.