Repository navigation
Conversation
ctrl+w (or alt+backspace) right after a "[Pasted ~5 lines]" placeholder deleted only the last word of its label, leaving "[Pasted ~5 " behind with the pasted text detached from it; ctrl+u and ctrl+k did the same when the line edge cut into a placeholder. Backspace and delete already removed it whole. The cause is in @opentui/core: its extmark controller's deleteRange, which every word and line delete goes through, trimmed a virtual extmark instead of treating it as one unit. The fix is upstream as anomalyco/opentui#1628; patches/@OpenTui%2Fcore@0.4.5.patch backports it to the pinned 0.4.5 until a release with it is adopted. deleteRange now widens its range over every virtual extmark it cuts into.
… text input_undo ran the textarea's own history, which steps back one character at a time, so taking back a paragraph took dozens of presses. It knew nothing of the prompt's parts: undoing the deletion of a "[Pasted ~N lines]" placeholder brought its label back as plain text with the pasted content gone. A submit cleared it, so text lost to a stray submit or ctrl+u could only be found again through the history. The prompt now keeps its own history (src/prompt/undo.ts) and binds input.undo and input.redo to it while focused. Typing is grouped by word: a group ends where a new word starts, after a pause over a second, when the caret moves, or between typing and deleting. A paste, a word or line delete, a newline, clearing, recalling history and a submit are each one step. Every entry records the text, the parts with their pasted content, the mode and the caret, and undo restores them together. The history lives outside the prompt component, so after a submit undo brings back what was sent, even once the route has moved to the new session, without touching the running turn. prompt.undo_depth sets how many steps are kept (default 500). The default keys are unchanged; keybinds.mdx shows how to move suspend off ctrl+z and use ctrl+z / ctrl+shift+z.
…der says
A paste of three lines or more, or over 150 characters, always became
"[Pasted ~N lines]", which says nothing about what was pasted; only the
global toggle could change it.
prompt.paste_summary in tui.json sets the line and character
thresholds and the placeholder format, with {lines}, {characters},
{bytes} and an {excerpt} of the paste's start, whose length is
configurable. pasteSummary (src/prompt/paste.ts) builds it and keeps it
on one line. The defaults reproduce the previous rule and label
exactly; the toggle still turns summarizing off.
… and todos Many parts of the TUI show something a keybind or slash command acts on, but did nothing when clicked. Each now runs that command through the keymap, or copies what it shows: - prompt meta row: the agent, model and variant open their pickers; the "tab agents" and "ctrl+p commands" hints run agent.cycle and the command palette; "esc interrupt" runs session.interrupt, so two clicks interrupt like two esc presses; - usage below the prompt and the sidebar Context lines open /status; - the directory below the prompt and in the sidebar and home footers is copied; - the model in an assistant footer opens the model picker on the model that turn ran on (DialogModel takes a current model); - the sidebar title renames the session; an MCP row connects or disconnects that server without opening /mcps (the toggle, status refresh and in-flight guard move from DialogMcp into local.mcp); a Modified Files row opens /diff at that file (diff route `file`); a todo is copied and appended to the prompt; - a session or message ID (ses_, msg_) is copied wherever it is drawn. ui/id-click.ts reads it back from the cells under the pointer inside the clicked renderable, and message and tool click handlers stand down when one is under the pointer; - the home footer's MCP count opens /status and "Connect provider" opens /connect. ui/click.ts runs an action only for a left press and release on the same cell that leaves no text selected, so drag-to-copy keeps working on all of these elements.
… inline Once a paste became "[Pasted ~N lines]" its text could not be seen or changed without sending it or opening the whole prompt in $EDITOR. Clicking a pasted-text placeholder opens DialogPaste: the text in the prompt's own editor, a textarea with the same input keybinds, mouse caret placement and grouped undo, where enter adds a line. Closing it (esc, ctrl+c, a click outside) saves: the part gets the edited text, and the label is rebuilt with pasteLabel when the text changes it, such as its line count. Inline replaces the placeholder with the text, and saving empty text removes it. Both are one undo step in the prompt. The full-app prompt test harness moves to test/fixture/prompt-app.ts, now shared by the undo and paste tests, and gains clicks and frames.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
1 task done
Nowaker
added a commit
to Nowaker/opencode
that referenced
this pull request
Oct 11, 2026
Session record and five feature records for item 28: atomic placeholder deletes (opentui#1628 backport), configurable paste summary, raw paste on <leader>v, grouped prompt undo with fork ctrl+z defaults, and the click-to-edit paste dialog, with their upstream v1 PRs anomalyco#54457-anomalyco#54460 and anomalyco#54463, key-byte measurements through Vibeterm's tmux, and the vt-206 installs on desktop and m4max. AI-Tool: opencode 1.18.34-vt-194-907b3bc518 AI-Model: anthropic/claude-opus-5-5 AI-Variant: high AI-Platform: linux AI-Harness: Vibeterm 9343cff AI-Session-ID: ses_ed7634c31ffeH84yR0S99Ty8Nd
Clicking a paste placeholder in a tall terminal opened a dialog whose Inline button was below the bottom of the screen. The dialog starts a quarter of the way down (ui/dialog.tsx paddingTop), but the editor was sized as the full height minus 14 rows, so the dialog ran past the viewport by roughly a quarter of its height: 8 rows at 60 rows. The editor now gets the rows left below that offset, less the dialog's 6 rows of chrome and a one-row margin, and no more than the text needs; a longer paste scrolls inside it. A test pastes 50 lines at 16, 24 and 60 rows and clicks Inline; the 60-row case fails without the fix. The paste and undo app tests get a 30s default timeout, since the first test in each file also starts the whole app.
Nowaker
added a commit
to Nowaker/opencode
that referenced
this pull request
Oct 11, 2026
Session record and five feature records for item 28: atomic placeholder deletes (opentui#1628 backport), configurable paste summary, raw paste on <leader>v, grouped prompt undo with fork ctrl+z defaults, and the click-to-edit paste dialog, with their upstream v1 PRs anomalyco#54457-anomalyco#54460 and anomalyco#54463, key-byte measurements through Vibeterm's tmux, and the vt-206 installs on desktop and m4max. AI-Tool: opencode 1.18.34-vt-194-907b3bc518 AI-Model: anthropic/claude-opus-5-5 AI-Variant: high AI-Platform: linux AI-Harness: Vibeterm 9343cff AI-Session-ID: ses_ed7634c31ffeH84yR0S99Ty8Nd
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I'm aware v1 is now the maintenance branch and new features go to v2 only. This PR is here for others to use, and I'll submit the v2 version once I've migrated my whole plugin system to it.
Issue for this PR
Related: #8501.
Stacked on #54457 (atomic placeholder deletes), #54460 (undo history), #54458 (configurable paste summary, for relabelling an edited paste) and #53871 (clickable elements, for the click helper). Their commits are included; the change in this PR is the last commit,
feat(tui): open a paste placeholder's text by clicking it, to edit or inline.Type of change
What does this PR do?
Once a paste becomes
[Pasted ~N lines], its text cannot be seen or changed without sending it or opening the whole prompt in$EDITOR.Clicking a pasted-text placeholder opens a dialog with the text in the prompt's own editor: a textarea with the same input keybinds, mouse caret placement and grouped undo, where enter adds a line.
prompt.paste_summary.formatwhen the text changes it, such as its line count.Documented in
tui.mdx(Clickable elements, Paste summary).How did you verify your code works?
test/component/prompt-paste.test.tsxdrives the real TUI with a mouse click on the placeholder: an edit with a new line relabels it to[Pasted ~4 lines]and sends the edited text; an edit keeping the line count keeps the label; Inline puts the text in the prompt and undo puts the placeholder back; undo takes back a dialog edit. The full-app harness moves totest/fixture/prompt-app.ts, shared with the undo tests.bun typecheckandbun testinpackages/tui.zeroand enter then esc gave[Pasted ~4 lines], a click on Inline put the four lines in the prompt, and undo restored the placeholder.Checklist
This PR is AI generated, but under direct supervision and on request of @Nowaker.