Repository navigation
fix(desktop): delete old staged CLI versions - #53659
Merged
Merged
Conversation
Hona
enabled auto-merge (squash)
October 7, 2026 02:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop copies its bundled CLI to
userData/cli/<version>/and runs the background service from that copy. Packaged builds never deleted old copies, so each update added about 200 MB. One install had 7 versions (1.4 GB).cleanStagesin packaged builds too. Before, only dev isolated mode ran it.app.isPackaged || isolatedcheck. Plain dev builds run the CLI from the source tree, which must not be cleaned.installClistages the copy again when its folder is missing.v2 CLI command failedlog.Effect.tryPromisewraps theexecFileerror, so the log always showed "An error occurred in Effect.tryPromise" with empty stdout and stderr. It now reads them fromerror.cause. The version cache is now parsed with a schema instead oftypeofchecks.cleanStagestocli-stages.ts(no Electron import) and add a table test for upgrade, downgrade, prerelease, and only-current.Nothing else references the old copies. "Install CLI" (macOS) and the WSL and SSH remote installers copy the binary. The service's Windows retained-image links are in the global cache.