Repository navigation
fix(browser): persist session storage across restarts, prevent tab unmount on navigation, increase tunnel connection limit - #53453
Open
4Liberty wants to merge 1 commit into
Conversation
…rease tunnel limits
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves three interconnected issues affecting OpenCode's embedded browser pane:
opencode-browser-${crypto.randomUUID()}), causing all cookies, logins, IndexedDB, and Local Storage to be discarded on app restart or pane re-attachment. By switching topartition: "persist:opencode-browser", Electron persists session cookies and authentication state across restarts in the application's persistent partition directory.navigate->close(entry)->page.dispose(), causing the browser pane to be destroyed and fully reloaded from scratch upon refocus. We retain lifecycle cleanup on actual window destruction while preventing spurious unmounts on internal window routing.sockets.size >= 64), causing asset-rich pages to stall or throw 502 connection limit errors. We increase the connection ceiling to 512.Verification
Partitions/opencode-browser.