[mlimarenko]

Issue for this PR

Closes #53047

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

Passes the session error boundary's reset callback to the existing error page. For session load failures, the primary action becomes the localized Try again button and retries metadata without reloading the document. Callers without a retry callback keep Reload/Restart; not-found and incompatible-server actions are unchanged.

There is no automatic retry loop. Navigation already resets boundaries, so no extra navigation reset was added.

How did you verify your code works?

• Built-app regression failed before the fix because Try again was absent; after the fix, all three recovery cases passed.
• Six affected built-app tests passed: same-session retry, same-/cross-server navigation, tab navigation and deleted-session fallback.
• Browser tests: 139 passed, 0 failed. App typecheck and changed-file formatting/lint passed; lint warnings remain.
• Rendered QA at 1440×900 and 390×720, including keyboard retry and no document reload.
• Independent review found no demonstrated defect in the diff.

E2E typecheck still fails in unchanged performance probes (terminals/probe.ts:54 and session-timeline-stream-probe.ts:139). Remote-server-originating explicit retry is not separately covered. The full suite is deferred to CI.

Screenshots / recordings

The built-app regression captures desktop and narrow retry states and verifies that the original document survives recovery.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[github-actions]

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

1. Open an issue describing the bug/feature (if one doesn't exist)
2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

[mlimarenko]

Issue: #53047 (also linked with Closes #53047 in the description).

For the required v2 target, the default-branch PR-standards workflow's closingIssuesReferences-only check can produce a false needs:issue label. The existing v2 workflow already includes the PR-body fallback. Evidence and the request to bring that fallback to dev: #53040 (comment).

[mlimarenko]

Rebased onto v2 at f72a103a4b94fb9a467294877bf6243dd99c6bdc; current head is 28263b6f218ecb4df96b439690898b3f828dc94c. git range-diff confirms the patches are unchanged.

139 browser tests and all 3 built-app session metadata recovery tests passed. Native pre-push bun run check also passed (36 typecheck tasks).

The upstream test, check and nix-eval runs on this head are action_required, rather than failed tests. Could a maintainer approve the fork workflow runs? Test run.

[mlimarenko]

Rebased onto current v2 at 8eb2ebd96cb2e25f9607f753e892a533628b8d46. New head: cb1defdfb798fe25edf25917db2a6b75a854fff7.

Resolved the upstream formatting/rename/import conflicts while retaining the fix's behavior. 167 browser tests and all 3 built-app session metadata recovery scenarios passed. The native pre-push bun run check also passed all 36 tasks. GitHub reports this head as conflict-free.

The upstream workflow runs still require maintainer approval rather than reporting test failures. Could a maintainer approve the test run and the associated check/nix-eval runs?

[mlimarenko]

Rebased onto v2 at 216c31174. Current head: 4d58ef60d68119efee687db9149028b1ad360660.

The targeted session-resolution/router browser tests and the built-app session metadata retry regression passed. The patch is unchanged according to git range-diff. A broader browser-suite attempt had 166 passes and one unrelated Playwright configuration test timeout (5 seconds); that full suite is not claimed green.

The native pre-push bun run check passed on this head. Full upstream CI remains subject to maintainer approval for fork workflow runs; it is not claimed green. Could a maintainer approve the test, check, and nix-eval workflows?

[mlimarenko]

Rebased onto current v2 at 7d179e83f42a9bb6377b6f34d8d4fcbf04707621 (package version 2.0.26). New head: 730235bed284fed19e89facf1982638a3bebdf5c.

The patch is unchanged according to git range-diff. All 10 targeted session-resolution/router browser tests and all 3 built-app session metadata recovery regressions passed. The native pre-push bun run check passed all 36 tasks and the lease-protected push completed successfully. Existing lint warnings remain.

The description still references Closes #53047. Full upstream CI is not claimed green; fork workflows may require maintainer approval.

Base clarification: release commit 9b4ec5714d481559990db0a816d5dec19541a814 is a sibling of the current development line, not its ancestor; these PRs target and are rebased onto upstream/v2 as requested.

[mlimarenko]

Rebased onto v2 at 4617210822bdbb31e5749751afbfb4584ccedac8; head: 5031d46956785ef54dbe05aaa7e0f20f27d964d3. git range-diff confirms the patch is unchanged.

Passed 10 focused browser tests, all 3 built-app metadata failure/recovery tests (including desktop/narrow keyboard retry without document reload), and native pre-push bun run check (36 typecheck tasks; lint warnings remain). The PR's current dev target is unchanged.

Upstream CI is not green: check, test, and nix-eval on this exact head are action_required and need maintainer approval. PR standards passed.

[mlimarenko]

Rebased onto current dev at 34d8ded0c58dd66808c1d60e081e8c66da12a896, rather than the old v2 alias. Published head: 94deb98fbb04965c5ecba3037dfbdda3996f1812.

Resolved the new whole-file GUI lint findings with spacing and an explained error-boundary suppression. Ten focused browser tests and app typecheck passed; the existing three rendered recovery checks also passed. Required lint:changed and the native pre-push gate passed (36/36 typecheck tasks).

The exact-head test, check, and nix-eval workflows are action_required, not green; maintainer approval is still needed. PR standards passed.