Skip to content

feat(trajectory): moves along its shape with the body, not at a constant speed (0.9.0) - #7

Merged
PPierzc merged 1 commit into
mainfrom
feat/root-follows-body-speed
Sep 29, 2026
Merged

PPierzc merged 1 commit into
mainfrom
feat/root-follows-body-speed

Conversation

@PPierzc

@PPierzc PPierzc commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Holding the trajectory to a constant speed along a line or arc left each stride's speed-up and slow-down in the pose. Played in place, the body floated forward and back: 13 cm on a run.

  • The shape (still / line / arc / bezier) is chosen by how well it fits across the travel path.
  • Along the shape, the trajectory follows the body's COM, projected onto a guide that runs on past the shape's ends. A line runs on straight, an arc on round, a Bezier straight from its ends.
  • Lines are fitted by their principal direction, so a stop-and-turn-back take goes out and back along one line.
  • Breaking change to the wire format: the + distance curve models are gone. params gains speed_range and drops key_times_s and distance_keys_m. Docs updated.

Tests: test_in_place_the_body_does_not_float_forward_and_back; the ramp test now checks that the speed varies. All 100 tests pass.

Measured in Blender with the same method in the addon (COM float along the facing, in place): run 13.5 → 2.1 cm, curving walk 3.5 → 1.4 cm, loop 3.1 → 0.7 cm.

Version bumped to 0.9.0, not tagged yet.

🤖 Generated with Claude Code

…ant speed (0.9.0)

A constant speed along a line or arc left each stride's speeding up and
slowing down in the pose: played in place the body floated forward and
back (13 cm on a run). The shape (still, line, arc, Bezier) is chosen by
how well it fits across the travel path; along it the trajectory follows
the body's COM, projected onto a guide that runs on past the shape's ends.
Lines fit by their principal direction (a stop-and-turn-back goes out and
back along one). Models are now just still/line/arc/bezier; params gain
speed_range and drop the distance keys.

Same as the Blender addon's inplace.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e88d3c3f-5d97-49ca-af5d-0fc98d07a8e9

📥 Commits

Reviewing files that changed from the base of the PR and between c26042f and 27c6e0f.

📒 Files selected for processing (5)
  • docs/docs/reference/response.mdx
  • pyproject.toml
  • src/motionmcp/__init__.py
  • src/motionmcp/trajectory.py
  • tests/test_trajectory.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PPierzc
PPierzc merged commit c0919bc into main Sep 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant