Null safe corrections - #87
Open
adamlofts wants to merge 20 commits into
Open
Conversation
…y/angular-v8 Bump to Angular v8 pre-release
Added Dart 3 support
requestAnimationFrame() callbacks are converted with .toJS, which needs the parameter type written out; an inferred dynamic parameter is not a valid JS function type. Type them `double`, and hoist the two callbacks in dom_service into named local functions so theirs can be typed too. dom_ruler passed classList.add/remove to forEach as tear-offs. Tear-offs of external extension type interop members are disallowed, and it is a compile- to-JS error rather than an analysis one, so use explicit loops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of places where values can be null.