This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix highlight when using animate#2063
Open
gboros wants to merge 1 commit into
Open
Conversation
Contributor
|
HI @gboros can you show a working an non working example for me? |
Author
|
hi |
Jefiozie
reviewed
Feb 5, 2018
Jefiozie
left a comment
Jefiozie
left a comment
Contributor
There was a problem hiding this comment.
Could you make a test for this? So that future adjustments won’t break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when animate is used, the dropdown is not scrolled to the selected item - this commit calls "_ensureHighlightVisible" in this case, to fix it