Add performance module and 1 code snippet - #1068
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
kkuan2011
left a comment
kkuan2011
left a comment
There was a problem hiding this comment.
Looks good once comments are addressed!
| import kotlinx.coroutines.Dispatchers | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| private object LaunchTimeSnippet { |
There was a problem hiding this comment.
Do we need to put the activity in a private object?
| } | ||
|
|
||
| android { | ||
| namespace = "com.example.performance" |
There was a problem hiding this comment.
nit: can we add android in there?
com.example.android.performance?
and same for applicationId below too
| --> | ||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | ||
|
|
||
| <application /> |
There was a problem hiding this comment.
should we add the MainActivity here instead of having an empty manifest?
|
|
||
| dependencies { | ||
| val composeBom = platform(libs.androidx.compose.bom) | ||
| implementation(composeBom) |
There was a problem hiding this comment.
are all these dependencies required? if not, can you remove any unused ones?
2 participants
This PR is to add a
performancemodule so that hard-coded snippets in Performance DAC can be migrated to this repo. Once this PR is merged, subsequent PRs with actual content will follow.The module mirrors the initial minimalistic structure of
:media, taking the namespacecom.example.performance.It contains one migrated snippet from Performance so that the module is not empty.