Skip to content

Add Navigation 3 deep link snippets - #1004

Open
bsagmoe wants to merge 18 commits into
mainfrom
bsagmoe/nav3-deeplinks
Open

Add Navigation 3 deep link snippets#1004
bsagmoe wants to merge 18 commits into
mainfrom
bsagmoe/nav3-deeplinks

Conversation

@bsagmoe

@bsagmoe bsagmoe commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This PR adds code snippets for Navigation 3 deep links documentation.

@bsagmoe
bsagmoe requested a review from a team as a code owner August 3, 2026 15:48
@bsagmoe
bsagmoe requested a review from riggaroo August 3, 2026 15:48
@snippet-bot

snippet-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 28 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bsagmoe
bsagmoe marked this pull request as draft August 3, 2026 16:13
@bsagmoe

bsagmoe commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Note: The build will fail until the dependency is updated to the non-snapshot beta release tomorrow, which includes the RequestExtras changes.

@bsagmoe
bsagmoe requested a review from dturner August 25, 2026 16:56
@bsagmoe
bsagmoe marked this pull request as ready for review August 25, 2026 17:09
@bsagmoe
bsagmoe requested a review from a team as a code owner August 25, 2026 17:09
defaultConfig {
applicationId = "com.example.datastore.snippets"
minSdk = 23
minSdk = 24

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why upgrading the minSdk of this module?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build was failing otherwise (might be related to the fact that I'm using a SNAPSHOT build for Nav 3). The beta for Nav 3 1.2 comes out tomorrow, so I'll double check if this change is necessary then.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's necessary because the datastore module depends on Nav 3 and, with the recent Jetpack shift to minSdk 24 (https://issuetracker.google.com/474169350), Nav 3 1.2.0 has a minSdk of 24.

Refactor match request snippet to demonstrate withBackStack and explicit matcher collation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants