Add Navigation 3 deep link snippets - #1004
Open
bsagmoe wants to merge 18 commits into
Open
Conversation
bsagmoe
marked this pull request as draft
August 3, 2026 16:13
…nd include AndroidEntryPoint
Contributor
Author
|
Note: The build will fail until the dependency is updated to the non-snapshot beta release tomorrow, which includes the RequestExtras changes. |
bsagmoe
marked this pull request as ready for review
August 25, 2026 17:09
yrezgui
requested changes
Aug 25, 2026
| defaultConfig { | ||
| applicationId = "com.example.datastore.snippets" | ||
| minSdk = 23 | ||
| minSdk = 24 |
Contributor
There was a problem hiding this comment.
Why upgrading the minSdk of this module?
Contributor
Author
There was a problem hiding this comment.
The build was failing otherwise (might be related to the fact that I'm using a SNAPSHOT build for Nav 3). The beta for Nav 3 1.2 comes out tomorrow, so I'll double check if this change is necessary then.
Contributor
Author
There was a problem hiding this comment.
It's necessary because the datastore module depends on Nav 3 and, with the recent Jetpack shift to minSdk 24 (https://issuetracker.google.com/474169350), Nav 3 1.2.0 has a minSdk of 24.
Refactor match request snippet to demonstrate withBackStack and explicit matcher collation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds code snippets for Navigation 3 deep links documentation.