feat(prs-556): enforce ABI trust posture in tvc-deploy and grpc-server - #455
Draft
pepe-anchor wants to merge 1 commit into
Draft
feat(prs-556): enforce ABI trust posture in tvc-deploy and grpc-server#455pepe-anchor wants to merge 1 commit into
pepe-anchor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why am I making this PR?
The deploy-time posture must be enforced at the tooling layer too: tvc-deploy should validate and sign the chosen posture into the manifest, and grpc-server should document its default.
What am I changing?
tvc-deploy: require a posture (unsigned or hex secp256k1 pubkey), validate the pubkey on-curve before writing it into the signed manifest, append the flag to pivotArgs for auditability. grpc-server: take the same flags but default to accept-unsigned (non-attested dev server) with a startup log line. CI workflows pass
--accept-unsigned-abisexplicitly.One change from the original #443: the grpc-server call-site update for the new
parse(req, key, &ParserConfig)signature now lands in the parser_app commit below,which is where the signature actually changes. #443 left grpc-server uncompilable
between the two commits. This PR keeps only the cmdline-flag work for grpc-server.
What is the Linear ticket?
PRS-556
What are the rollback steps?
Revert the commit and redeploy with manifest pivotArgs that omit the new flag.
Is this change backwards compatible?
tvc-deploy now refuses to build a manifest without a posture. CI workflows updated to pass explicit posture.
Does this require cross-team/service coordination?
Yes, deployments need a redeploy to pick up an explicit posture.
How do I know it works as designed? Which tests exercise this code?
tvc-deploy unit tests cover key validation (format, on-curve, off-curve) and XOR posture enforcement.
Verified at this commit:
cargo clippy --all-targets -- -D warningsclean.