Repository navigation
docs(platform): audit remaining v3 deprecations - #2547
benpsnyder wants to merge 4 commits into
Conversation
Record package inventory, migration paths, and separate acceptance criteria. Closes analogjs#2215 Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (7)
Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe Nitro renderer now uses route-rule and request Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change makes SSR route policy explicit, prevents request headers from overriding configured SSR behavior, enables SSR for product routes, and updates compatibility setup. Current coverage supports the intended behavior with no remaining merge-blocking risk. 🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (2 passed)
Full details: Linked Issues checkExplanation The linked issue requires a package-wide deprecation audit, Angular 20 impact analysis, and an implementation plan. The core audit file Resolution Include the contents or reviewable summary of Full details: Out of Scope Changes checkExplanation The changes include Node version updates, CI workflow changes, SSR route configuration, SSR renderer behavior changes, and related tests. These changes are outside the linked issue's documentation-only deprecation audit scope.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 3b40c9f
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Use the shared Node 24.15 pin on Nx agents and install the Playwright browsers used by tests. Skip only the root prepare build when the compiler matrix swaps Angular versions. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Reuse the verified route-policy fix from analogjs#2523 so client-only routes stay unrendered. Preserve internal request context and reject caller-supplied SSR bypass headers. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Document the remaining v3 deprecations, migration paths, and regression criteria across the published packages. Include the reviewed CI setup and SSR-policy prerequisites needed to validate the audit on alpha.
PR Checklist
Closes #2215.
Affected scope
Recommended merge strategy for maintainer [optional]
Commit preservation note [optional]
No commit boundaries need preservation.
What is the new behavior?
Maintainers get a current package inventory and a review sequence for the two public deprecations, the internal downlevel alias, and the proposed Angular 20 minimum. Each proposal records migration examples and acceptance checks. The audit distinguishes already-removed API middleware, an absent trpc package, and overlapping open compiler/tooling PRs from outstanding work.
The audit follows the issue's request for a deprecation plan; API removals and the Angular support-floor decision remain in their dedicated work. This branch also carries the reviewed CI setup and SSR-policy prerequisites described below so the complete PR can pass alpha's existing checks.
Test plan
4225f4509.git diff --check.pnpm nx test platform— 396 tests passed.pnpm nx run analog-app-e2e:e2e --args='tests/json-ld.spec.ts tests/ssr-policy.spec.ts --retries=0 --reporter=line'— all 10 tests passed, including all required build dependencies. The unchanged alpha baseline failed the client-only route case before the prerequisite was applied.Does this PR introduce a breaking change?
The proposed implementation PRs would introduce breaking changes on alpha and need their own regression evidence and migration notes.
Other information
Shared prerequisites from analogjs/analog#2541: Node 24.15.0 for the coordinator and Nx agents, Playwright-only browser installation, and isolated compiler-matrix installs (original commit
9d86fae). Also reuses the SSR route-policy fix from analogjs/analog#2523, already qualified in #2541 (original commit072ed54c), so client-only routes remain unrendered and caller headers cannot override SSR policy. These are existing prerequisite fixes, retained as separate commits for review. The existing test suites and support ranges are preserved.The previous audit draft analogjs/analog#2246 was closed without merging. This refreshes the plan against the current alpha architecture and package layout.
[optional] What gif best describes this PR or how it makes you feel?
Not applicable.