Skip to content

Change some custom nodes to be regular AstNodes - #44

Merged
jdpage merged 2 commits into
masterfrom
ast-consistency
Aug 10, 2018
Merged

Change some custom nodes to be regular AstNodes#44
jdpage merged 2 commits into
masterfrom
ast-consistency

Conversation

@jdpage

@jdpage jdpage commented Aug 9, 2018

Copy link
Copy Markdown
Collaborator

In particular, the entire jeff65.gold.storage module is gone, along with
jeff65.gold.passes.asm.AsmRun. As an additional advantage, some compiler
passes which were previously imperative are now pattern-based.

(This was rescued from PR #37 asm-blocks, where it was mixed in with a
bunch of other changes.)

In particular, the entire jeff65.gold.storage module is gone, along with
jeff65.gold.passes.asm.AsmRun. As an additional advantage, some compiler
passes which were previously imperative are now pattern-based.

(This was rescued from PR #37 asm-blocks, where it was mixed in with a
bunch of other changes.)
@coveralls

coveralls commented Aug 9, 2018

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 273

  • 10 of 14 (71.43%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 89.464%

Changes Missing Coverage Covered Lines Changed/Added Lines %
jeff65/gold/passes/lower.py 0 2 0.0%
jeff65/gold/passes/resolve.py 0 2 0.0%
Totals Coverage Status
Change from base Build 270: -0.2%
Covered Lines: 1490
Relevant Lines: 1657

💛 - Coveralls

@jdpage

jdpage commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator Author

I feel slightly guilty about the slight reduction in test coverage, but it's honestly due to the fact that I deleted some code that was covered, and the four relevant uncovered lines are related to lowering, which is probably about to get rewritten as I pull things into backends. SO I'M LETTING IT STAND

@jdpage
jdpage merged commit 77e181c into master Aug 10, 2018
@jdpage jdpage added this to the Infrastructure Stability milestone Aug 10, 2018
@jdpage
jdpage deleted the ast-consistency branch August 10, 2018 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants