HIPStdPar: add -Wl,-rpath next to -L$(TBB_LIBDIR) in MixAndMatch std_cpu_gpu - #192
Open
dannybaths wants to merge 1 commit into
Open
HIPStdPar: add -Wl,-rpath next to -L$(TBB_LIBDIR) in MixAndMatch std_cpu_gpu#192dannybaths wants to merge 1 commit into
dannybaths wants to merge 1 commit into
Conversation
…cpu_gpu Signed-off-by: Daniele Bagni <30289343+dannybaths@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
HIPStdPar/CXX/MixAndMatch/std_cpu_gpu/Makefilepasses the TBB directory to thelinker with
-Lonly:-Lis a link-time search path. It does not end up in the binary, so the dynamicloader has no idea where TBB lives. This change adds the matching rpath:
Why
On a machine with no TBB in the default loader path, the test links without
complaint and then fails to start:
The Makefile already detects TBB and already knows the directory, including the
copy ROCm ships under
lib/rocprofiler-systems, which is not on the defaultloader path. Nothing else is needed; the directory just has to be recorded in the
binary as well as used at link time.
Validation
MI300A / gfx942, ROCm with HIPStdPar. Focused run on upstream
main(20e93223):Unpatched upstream: 1/1 FAIL. The binary records no RUNPATH;
lddreportslibtbb.so.12 => not found; CTest fails at launch with the loader error above.With this change: 1/1 PASS. Example success marker:
AAC7 proof: current-main CTest on ROCm 10.0.0 — unpatched FAIL, patched PASS.
AAC6 no-regression: MI300A, Lmod
rocm/7.14.0, Slurm job19740onppac-pl1-s24-16— 1/1 PASS (StdParGpu Executor took 473 ms).