Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shapeinempty_like,full_like,ones_like, andzeros_likewhen using the defaultorder='K'.shapeis omitted.The shared helper currently checks
order != 'K'before acceptingshape, so the documented override is silently ignored with the default order. For example,ones_like(a, shape=(3,))retains a(2, 2)input shape instead of returning(3,).Validation
empty_likevalues are intentionally not read.45a002ab19f9021e982ed153826586bb79e41837native libraries and a namespace bootstrap. They are not full-package validation, a latest-native-baseline rebuild, GPU/hardware coverage or online CI.Scope
empty_like(shape=())is covered. Scalar filled-array creation (shape=()orshape=[]) has an existing limitation infull(also present withorder='C') and is not addressed here; this does not claim support for every shape. No native backend or order/layout behavior is changed.The added regression covers a documented option absent from the existing test and exercises the shared helper through all four callers.
Review
AI-assisted implementation and testing. A separate reviewer tested 384 additional cases, including integer shape overrides: all shape/dtype/template checks and 288 initialized-value checks passed.