Repository navigation
chore: remove APIs deprecated before 2.10 in akka-persistence-typed - #33039
Draft
johanandren wants to merge 3 commits into
Draft
johanandren wants to merge 3 commits into
johanandren wants to merge 3 commits into
Conversation
* Remove the javadsl snapshotSelectionCriteria overrides in EventSourcedBehavior, EventSourcedOnCommandBehavior and EventSourcedOnCommandWithReplyBehavior, deprecated in 2.6.5. They were not used by the implementation, override recovery instead. * Remove the scaladsl EventSourcedBehavior.withSnapshotSelectionCriteria, deprecated in 2.6.5, use withRecovery instead.
Contributor
Author
|
🤖 Reworded the migration guide intro to "deprecated in 2.10.0 or earlier", following the review on #33046. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Part of the 2.11 clean-up: one PR per module removes APIs deprecated in 2.9 or earlier, or in 2.10.0.
Removed
snapshotSelectionCriteriainEventSourcedBehavior,EventSourcedOnCommandBehaviorandEventSourcedOnCommandWithReplyBehavior(2.6.5). Nothing internal called it, so overriding it already had no effect.EventSourcedBehavior.withSnapshotSelectionCriteria(2.6.5)Kept on purpose (2.10.1 or later):
javadsl.Recovery.default, theEventSourcedBehaviorImplmetadata constructor,withReplicatedEventTransformation.Also: migration guide section (shared
## Removed deprecated APIsheading with the other removal PRs; keep one when rebasing); MiMa filters in2.11.0.backwards.excludes.Verified: root
Test/compile,akka-persistence-typed-tests/test(289), MiMa.Downstream (compile check against a snapshot with all 2.11 removals): no repo uses the removed members.