Skip to content

chore: remove APIs deprecated before 2.10 in akka-cluster-sharding - #33031

Draft
johanandren wants to merge 3 commits into
mainfrom
johan/agent/remove-deprecated-cluster-sharding
Draft

johanandren wants to merge 3 commits into
mainfrom
johan/agent/remove-deprecated-cluster-sharding

Conversation

@johanandren

Copy link
Copy Markdown
Contributor

🤖 Part of the 2.11 clean-up: one PR per module removes APIs deprecated in 2.9 or earlier, or in 2.10.0. Cross-DC deprecations (startProxy, shardRegionProxy with a data center) are left in place.

Removed

  • The 5 old ClusterShardingSettings.TuningParameters constructors and the 4 old ClusterShardingSettings constructors
  • passivateIdleEntityAfter and both withPassivateIdleAfter overloads (2.6.18)
  • ClusterShardingHealthCheckSettings(names, timeout) (2.8.0)

Kept on purpose: PersistentShardCoordinator (2.6.0), since state-store-mode = persistence is still supported. The 2.10.10 allocateShard/rebalance hooks are too recent.

Also: migration guide section (shared ## Removed deprecated APIs heading with the other removal PRs; keep one when rebasing); MiMa filters in 2.11.0.backwards.excludes.

Verified: Test/compile and MultiJvm/compile of akka-cluster-sharding and akka-cluster-sharding-typed, akka-docs Test/compile; settings, health check and passivation specs (48); MiMa. Multi-jvm specs not run.

Downstream (compile check against a snapshot with all 2.11 removals): no repo uses the removed akka-cluster-sharding APIs.

@johanandren

Copy link
Copy Markdown
Contributor Author

🤖 Reworded the migration guide intro and the MiMa filter comment to "deprecated in 2.10.0 or earlier", following the review on #33046.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant